Horton
Menu

Re: [PATCH] avoid double scanning in function byteain

Peter Eisentraut <peter@eisentraut.org>

View thread
From: Peter Eisentraut <peter@eisentraut.org>
To: Stepan Neretin <slpmcf@gmail.com>, Steven Niu <niushiji@gmail.com>
Cc: Kirill Reshke <reshkekirill@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-05-21T18:40:28Z
Lists: pgsql-hackers 
The relationship between patch 0001 and 0002 is unclear to me.  Are 
these incremental or alternatives?  The description doesn't make this clear.

Some of the changes in patch 0002 just appear to move code and comments 
around without changing anything substantial.  It's not clear why that 
is done, as it's not related to what the patch claims it does.

The main tests for the bytea type input formats are in 
src/test/regress/sql/strings.sql, so you should add any new tests there. 
  Maybe there are already enough tests there that you don't need any new 
ones.

Overall, I would consider the bytea "escaped" format kind of 
obsolescent.  But if you want to make it a bit faster with little other 
impact, why not.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Speed up byteain by not parsing traditional-style input twice.