Horton

Re: Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

David Steele <david@pgmasters.net>

View thread
From: David Steele <david@pgmasters.net>
To: Andrey Borodin <x4mmm@yandex-team.ru>, Alexey Kondratov <a.kondratov@postgrespro.ru>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Dmitry Dolgov <9erthalion6@gmail.com>, Michael Paquier <michael@paquier.xyz>, vladimirlesk@yandex-team.ru, dsarafan@yandex-team.ru
Date: 2019-03-07T07:26:54Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Move frontend-side archive APIs from src/common/ to src/fe_utils/

  2. Add -c/--restore-target-wal to pg_rewind

  3. Move routine definitions of xlogarchive.c to a new header file

  4. Move routine building restore_command to src/common/

  5. Integrate recovery.conf into postgresql.conf

On 3/6/19 5:38 PM, Andrey Borodin wrote:
>> 20 февр. 2019 г., в 17:06, Alexey Kondratov <a.kondratov@postgrespro.ru> написал(а):
> 
> The new patch is much smaller (less than 400 lines) and works as advertised.
> There's a typo "retreive" there.
> 
> These lines look a little suspicious:
> 		char  postgres_exec_path[MAXPGPATH],
> 				  postgres_cmd[MAXPGPATH],
> 				  cmd_output[MAX_RESTORE_COMMAND];
> Is it supposed to be any difference between MAXPGPATH and MAX_RESTORE_COMMAND?
> 
> Besides this, patch looks fine to me.

This patch appears to need attention from the author so I have marked it 
Waiting on Author.

Regards,
-- 
-David
david@pgmasters.net