Re: MultiXact\SLRU buffers configuration

Gilles DAROLD <gilles@darold.net>

From: Gilles Darold <gilles@darold.net>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Alexander Korotkov <aekorotkov@gmail.com>, Anastasia Lubennikova <a.lubennikova@postgrespro.ru>, Daniel Gustafsson <daniel@yesql.se>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-12-09T10:51:36Z
Lists: pgsql-hackers
Hi Andrey,

Thanks for the backport. I have issue with the first patch "Use shared 
lock in GetMultiXactIdMembers for offsets and members" 
(v1106-0001-Use-shared-lock-in-GetMultiXactIdMembers-for-o.patch) the 
applications are not working anymore when I'm applying it. Also PG 
regression tests are failing too on several part.


    test insert_conflict              ... ok
    test create_function_1            ... FAILED
    test create_type                  ... FAILED
    test create_table                 ... FAILED
    test create_function_2            ... FAILED
    test copy                         ... FAILED
    test copyselect                   ... ok
    test copydml                      ... ok
    test create_misc                  ... FAILED
    test create_operator              ... FAILED
    test create_procedure             ... ok
    test create_index                 ... FAILED
    test index_including              ... ok
    test create_view                  ... FAILED
    test create_aggregate             ... ok
    test create_function_3            ... ok
    test create_cast                  ... ok
    test constraints                  ... FAILED
    test triggers                     ... FAILED
    test inherit                      ...
    ^C



This is also where I left my last try to back port for PG11, I will try 
to fix it again but it could take time to have it working.

Best regards,

-- 
Gilles Darold


Le 08/12/2020 à 18:52, Andrey Borodin a écrit :
> Hi Gilles!
>
> Many thanks for your message!
>
>> 8 дек. 2020 г., в 21:05, Gilles Darold <gilles@darold.net> написал(а):
>>
>> I know that this report is not really helpful
> Quite contrary - this benchmarks prove that controllable reproduction exists. I've rebased patches for PG11. Can you please benchmark them (without extending SLRU)?
>
> Best regards, Andrey Borodin.
>

Commits

  1. Rework new SLRU test with injection points

  2. injection_point: Add injection_points.stats

  3. injection_points: Add initialization of shmem state when loading module

  4. Add injection-point test for new multixact CV usage

  5. Use conditional variable to wait for next MultiXact offset

  6. Improve performance of subsystems on top of SLRU

  7. Adjust VACUUM hastup LP_REDIRECT comments.

  8. Test replay of regression tests, attempt II.