Horton

Thread

Commits

  1. psql: Tab completion for JOIN ... ON/USING

  2. psql: Tab completion for JOIN ... USING column list

  3. psql: Tab completion for LATERAL joins

  1. Improved psql tab completion for joins

    Andreas Karlsson <andreas@proxel.se> — 2024-11-16T16:59:18Z

    Hi,

Here is a set of small patches which improve the tab completion of joins 
in psql. The completion of select queries and DML is very primitive in 
psql but since we already have completion of relation names after FROM 
and JOIN I think these small additions fit and at least I find them 
useful myself. I don't use USING that much in application code but when 
writing ad hoc queries I use it quite a bit.

## 0001-Complete-LATERAL-keyword-for-joins.patch

Adds support for the LATERAL keyword after JOIN.

## 0002-Complete-ON-and-USING-keywords-for-joins.patch

Adds completion of the ON and USING keywords.

## 0002-Complete-ON-and-USING-keywords-for-joins.patch

Adds completion of the first USING column.

Andreas

  2. Re: Improved psql tab completion for joins

    Tomas Vondra <tomas@vondra.me> — 2024-12-07T23:06:08Z

    Hi,

On 11/16/24 17:59, Andreas Karlsson wrote:
> Hi,
> 
> Here is a set of small patches which improve the tab completion of joins
> in psql. The completion of select queries and DML is very primitive in
> psql but since we already have completion of relation names after FROM
> and JOIN I think these small additions fit and at least I find them
> useful myself. I don't use USING that much in application code but when
> writing ad hoc queries I use it quite a bit.
> 
> ## 0001-Complete-LATERAL-keyword-for-joins.patch
> 
> Adds support for the LATERAL keyword after JOIN.
> 
> ## 0002-Complete-ON-and-USING-keywords-for-joins.patch
> 
> Adds completion of the ON and USING keywords.
> 
> ## 0002-Complete-ON-and-USING-keywords-for-joins.patch
> 
> Adds completion of the first USING column.
> 

Thanks. On a cursory look these all seem reasonable to me. I'll do a bit
more review to make sure I didn't miss anything, and then I intend to
get this committed ...


regards

-- 
Tomas Vondra

  3. Re: Improved psql tab completion for joins

    Tomas Vondra <tomas@vondra.me> — 2024-12-16T17:51:49Z

    
On 12/8/24 00:06, Tomas Vondra wrote:
> Hi,
> 
> On 11/16/24 17:59, Andreas Karlsson wrote:
>> Hi,
>>
>> Here is a set of small patches which improve the tab completion of joins
>> in psql. The completion of select queries and DML is very primitive in
>> psql but since we already have completion of relation names after FROM
>> and JOIN I think these small additions fit and at least I find them
>> useful myself. I don't use USING that much in application code but when
>> writing ad hoc queries I use it quite a bit.
>>
>> ## 0001-Complete-LATERAL-keyword-for-joins.patch
>>
>> Adds support for the LATERAL keyword after JOIN.
>>
>> ## 0002-Complete-ON-and-USING-keywords-for-joins.patch
>>
>> Adds completion of the ON and USING keywords.
>>
>> ## 0002-Complete-ON-and-USING-keywords-for-joins.patch
>>
>> Adds completion of the first USING column.
>>
> 
> Thanks. On a cursory look these all seem reasonable to me. I'll do a bit
> more review to make sure I didn't miss anything, and then I intend to
> get this committed ...
> 

OK, pushed. Similarly to tho the other tab completion patches I
committed today, I chose not to squash the parts, even though these
changes seem to be in the same area. Seems tidier this way.

thanks!

-- 
Tomas Vondra

  4. Re: Improved psql tab completion for joins

    Andreas Karlsson <andreas@proxel.se> — 2024-12-16T18:35:18Z

    On 12/16/24 6:51 PM, Tomas Vondra wrote:
> OK, pushed. Similarly to tho the other tab completion patches I
> committed today, I chose not to squash the parts, even though these
> changes seem to be in the same area. Seems tidier this way.

Thanks!

Personally I do not care either way. Most committers seem to prefer a 
bit more squashed patches than I do but either is fine.

Andreas