Horton

Re: Avoid possible memory leak (src/common/rmtree.c)

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Ranier Vilela <ranier.vf@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2023-07-25T14:45:22Z
Lists: pgsql-hackers 
> On 25 Jul 2023, at 16:31, Ranier Vilela <ranier.vf@gmail.com> wrote:

> rmtree function can leak 64 bytes per call, 
> when it can't open a directory.

Skimming the tree there doesn't seem to be any callers which aren't exiting or
ereporting on failure so the real-world impact seems low.  That being said,
silencing static analyzers could be reason enough to delay allocation.

--
Daniel Gustafsson

Commits

  1. Avoid memory leak in rmtree() when path cannot be opened