Thread

Re: remove obsolete comment in AtEOXact_Inval

Daniel Gustafsson <daniel@yesql.se> — 2026-05-08T08:54:22Z

> On 27 Oct 2025, at 04:50, Chao Li <li.evan.chao@gmail.com> wrote:
> 
>> On Oct 27, 2025, at 10:43, Steven Niu <niushiji@gmail.com> wrote:
>> 
>> Hi, Hackers,
>> 
>> When I read the code, I noticed there is one line of comment in function AtEOXact_Inval() which is obviously obsolete.
>> 
>>    "This should be called as the last step in processing a transaction"  
>> 
>> Steven<0001-PATCH-remove-obsolete-comment-in-AtEOXact_Inval.patch>
> 
> +1
> 
> The comment of "void AtEOXact_Inval(bool isCommit):
> ```
> * Note:
> * This should be called as the last step in processing a transaction.
> ```
> Was added 29 years ago.

This comment was part of the Postgres95 import, and was originally added to the
function RegisterInvalid() which in turn was committed by Cimarron Taylor in
1990.  I agree that it's no longer helpful and will go ahead to remove it shortly
unless someone disagrees.

--
Daniel Gustafsson