Re: COPY FROM performance improvements
Luke Lonergan <llonergan@greenplum.com>
From: "Luke Lonergan" <LLonergan@greenplum.com>
To: "Alvaro Herrera" <alvherre@surnet.cl>
Cc: "Bruce Momjian" <pgman@candle.pha.pa.us>, "Alon Goldshuv" <agoldshuv@greenplum.com>, pgsql-patches@postgresql.org
Date: 2005-06-27T06:23:05Z
Lists: pgsql-performance
Attachments
- fast_copy_V11_8.1.patch (application/octet-stream) patch
Alvaro, > Am I the only one annoyed by the fact that the patch is not very nice to > 80-columns-wide terminals? It doesn't need to be a rigid rule but I > think the code looks much better if it's not too wide. This code is > wide already, but I think we should be making it better, not the other > way around. Yup - fixed (as well as I can without mucking readability). > Also, your text editor seems to be messing the indentation of comments > when there are ( or other symbols in the comment text. (Maybe this > doesn't matter a lot because pgindent will fix it, but still -- it makes > it slightly more difficult to read.) Yah - I think I fixed several mis-indented comments. I'm using vim with tabstop=4. I personally don't like tabs in text and would prefer them expanded using spaces, but that's a nice way to make small formatting changes look huge in a cvs diff. See attached - only formatting changes included. - Luke