Thread

Re: [PATCH] Fix ProcKill lock-group vs procLatch recycle race

Andrey Borodin <x4mmm@yandex-team.ru> — 2026-05-07T11:57:28Z

> On 7 May 2026, at 03:54, Michael Paquier <michael@paquier.xyz> wrote:
> 
> +#include "../injection_points/injection_point_condition.h"
> 
> Hmm.  I would not see a problem in just moving all that to the module
> injection_points instead, and keep it there, including your TAP test.
> Noah has done something similar for its removable_cutoff() business,
> and we are living well with it.  One issue with the structure you are
> proposing is that I suspect that it makes some installcheck scenarios
> more iffy to deal with.  More callbacks in the test module is fine.

Thanks, Michael!

Done so. I still keep Vlad's injection_point_condition.h though.
It seems useful. But no more Meson\Makefile changes, and new sql stuff lives
now near removable_cutoff() SQL.

Vlad, there are 2 patches in the patchset again :)

Now we need an expert in ProcKill(). I also will review the patchset in more detail,
but, perhaps, after pgconf.dev.


Best regards, Andrey Borodin.