Re: plperl and inline functions -- first draft
Alexey Klyukin <alexk@commandprompt.com>
From: Alexey Klyukin <alexk@commandprompt.com>
To: Joshua Tolley <eggyknap@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>,
pgsql-hackers@postgresql.org
Date: 2009-11-20T14:34:45Z
Lists: pgsql-hackers
On Nov 20, 2009, at 2:04 AM, Joshua Tolley wrote: > On Wed, Nov 18, 2009 at 12:38:00PM +0200, Alexey Klyukin wrote: >> Yes, current_call_data can't be allocate in the SPI memory context, since it's used to extract the result after SPI_finish is called, although it doesn't lead to problems here since no result is returned. Anyway, I'd move SPI_connect after the current_call_data initialization. >> >> I also noticed that no error context is set in the inline handler, not sure whether it really useful except for the sake of consistency, but in case it is - here is the patch: > > Makes sense on both counts. Thanks for the help. How does the attached look? These two problems seem to be fixed now, thank you. -- Alexey Klyukin http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc