Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: Michael Paquier <michael@paquier.xyz>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Jacob Champion <jchampion@timescale.com>, Tobias Bussmann <t.bussmann@gmx.net>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Mark Guertin <markguertin@gmail.com>, pgsql-bugs@lists.postgresql.org

Date: 2023-07-20T10:36:52Z

Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Skip .DS_Store files in server side utils
- d3fdfdcd1c7f 13.15 landed
- c1fc502f595b 17.0 landed
- aeee173d2292 14.12 landed
- 76bb6dd2e56c 12.19 landed
- 29f00523808a 15.7 landed
- 103235888d9e 16.3 landed

Attachments

v7-0001-Skip-.DS_Store-files-in-server-side-utils.patch (application/octet-stream) patch v7-0001

> On 20 Jul 2023, at 09:47, Michael Paquier <michael@paquier.xyz> wrote:

> Hmm.  Are you sure that this is correct for pg_rewind?  This should
> work when using a local source with --source-pgdata, but under a
> remote source with --source-pgdata, I get the impression that we'd
> still copy a .DS_store into the target's data folder.

Ah, good point.  The updated patch should work for both by moving the check
into the filemap.

--
Daniel Gustafsson