Re: CI: Add task that runs pgindent
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Jelte Fennema-Nio <me@jeltef.nl>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
Florents Tselai <florents.tselai@gmail.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
Nazir Bilal Yavuz <byavuz81@gmail.com>
Date: 2025-10-22T12:06:44Z
Lists: pgsql-hackers
> On 22 Oct 2025, at 11:24, Jelte Fennema-Nio <me@jeltef.nl> wrote: > > On Wed, 22 Oct 2025 at 10:49, Daniel Gustafsson <daniel@yesql.se> wrote: >> Orange cross and Red cross are probably too similar to be easily discernible >> for people with color blindness. Since the patch is technically "green", what >> do you think about just changing the checkmark on such patches? > > Good point. I changed it to an orange triangle + exclamation point now > (see attached). And everything also seems to work as expected in the > commitfest app prod environment, because this patch now shows as > correctly as yellow: https://commitfest.postgresql.org/patch/6148/ I like the different shape and symbol, but I would probably keep it green to indicate that it's informational rather than actionable. We don't want a flurry of patch re-submissions with only whitespace changes eating CI resources when the previous build was successful. Just my €0,02. -- Daniel Gustafsson