I had overlooked the fact that some fmgr-callable functions return void
Tom Lane <tgl@sss.pgh.pa.us>
I had overlooked the fact that some fmgr-callable functions return void --- ie, they're only called for side-effects. Add a PG_RETURN_VOID() macro and use it where appropriate. This probably doesn't change the machine code by a single bit ... it's just for documentation.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/gist/gist.c | modified | +3 −3 |
| src/backend/access/gist/gistscan.c | modified | +4 −4 |
| src/backend/access/hash/hash.c | modified | +7 −7 |
| src/backend/access/nbtree/nbtree.c | modified | +7 −7 |
| src/backend/access/rtree/rtproc.c | modified | +3 −4 |
| src/backend/access/rtree/rtree.c | modified | +3 −3 |
| src/backend/access/rtree/rtscan.c | modified | +5 −5 |
| src/backend/utils/adt/arrayfuncs.c | modified | +3 −6 |
| src/backend/utils/adt/selfuncs.c | modified | +2 −3 |
| src/include/fmgr.h | modified | +4 −1 |