Horton

Fix some inconsistencies with memory freeing in pg_createsubscriber

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: ff6d9cfcb17e48c313aefe8fc65cdaeacd8766bf
Author: Michael Paquier <michael@paquier.xyz>
Date: 2025-02-12T08:11:47Z
Releases: 17.4 
Fix some inconsistencies with memory freeing in pg_createsubscriber

The correct function documented to free the memory allocated for the
result returned by PQescapeIdentifier() and PQescapeLiteral() is
PQfreemem().  pg_createsubscriber.c relied on pg_free() instead, which
is not incorrect as both do a free() internally, but inconsistent with
the documentation.

While on it, this commit fixes a small memory leak introduced by
4867f8a555ce, as the code of pg_createsubscriber makes this effort.

Author: Ranier Vilela
Reviewed-by: Euler Taveira
Discussion: https://postgr.es/m/CAEudQAp=AW5dJXrGLbC_aZg_9nOo=42W7uLDRONFQE-gcgnkgQ@mail.gmail.com
Backpatch-through: 17

Files

PathChange+/−
src/bin/pg_basebackup/pg_createsubscriber.c modified +13 −12

Discussion