Fix ExecOpenScanRelation to take a lock on a ROW_MARK_COPY relation.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: feeb526cfe33657b8aa8b0cdd45b2ef0d9898877
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2015-03-24T19:53:06Z
Releases: 9.5.0
Fix ExecOpenScanRelation to take a lock on a ROW_MARK_COPY relation.

ExecOpenScanRelation assumed that any relation listed in the ExecRowMark
list has been locked by InitPlan; but this is not true if the rel's
markType is ROW_MARK_COPY, which is possible if it's a foreign table.

In most (possibly all) cases, failure to acquire a lock here isn't really
problematic because the parser, planner, or plancache would have taken the
appropriate lock already.  In principle though it might leave us vulnerable
to working with a relation that we hold no lock on, and in any case if the
executor isn't depending on previously-taken locks otherwise then it should
not do so for ROW_MARK_COPY relations.

Noted by Etsuro Fujita.  Back-patch to all active versions, since the
inconsistency has been there a long time.  (It's almost certainly
irrelevant in 9.0, since that predates foreign tables, but the code's
still wrong on its own terms.)

Files

PathChange+/−
src/backend/executor/execMain.c modified +4 −0
src/backend/executor/execUtils.c modified +3 −1