Improve stability of test with vacuum_truncate in reloptions.sql
Michael Paquier <michael@paquier.xyz>
Improve stability of test with vacuum_truncate in reloptions.sql This test has been using a simple VACUUM with pg_relation_size() to check if a relation gets physically truncated or not, but forgot the fact that some concurrent activity, like checkpoint buffer writes, could cause some pages to be skipped. The second test enabling vacuum_truncate could fail, seeing a non-empty relation. The first test would not have failed, but could finish by testing a behavior different than the one aimed for. Both tests gain a FREEZE option, to make the vacuums more aggressive and prevent page skips. This is similar to the issues fixed in c2dc1a7. Author: Arseny Sher Reviewed-by: Masahiko Sawada Discussion: https://postgr.es/m/87tuotr2hh.fsf@ars-thinkpad backpatch-through: 12
Files
| Path | Change | +/− |
|---|---|---|
| src/test/regress/expected/reloptions.out | modified | +4 −2 |
| src/test/regress/sql/reloptions.sql | modified | +4 −2 |
Discussion
- Flaky vacuum truncate test in reloptions.sql 17 messages · 2021-03-29 → 2021-04-05