Make some sanity-check elogs more verbose

Alvaro Herrera <alvherre@alvh.no-ip.org>

Commit: fe051291550ab88267ce3104e9833925bf757393
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2020-11-23T16:10:03Z
Releases: 14.0
Make some sanity-check elogs more verbose

A few sanity checks in funcapi.c were not mentioning all the possible
clauses for failure, confusing developers who fat-fingered catalog data
additions.  Make the errors more detailed to avoid wasting time in
pinpointing mistakes.

Per complaint from Craig Ringer.
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAMsr+YH7Kd87A3cU5m_wKo46HPQ46zFv5wesFNL0YWxkGhGv3g@mail.gmail.com

Files

PathChange+/−
src/backend/utils/fmgr/funcapi.c modified +15 −10

Discussion