Fix failure-to-copy bug in commit 6f6b99d13.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: fdf87ed451ef1ccb710f4e65dddbc6da17e92ba7
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2017-09-09T00:45:31Z
Releases: 11.0
Fix failure-to-copy bug in commit 6f6b99d13.

The previous coding of get_qual_for_list() was careful to copy everything
it was using from the input data structure.  The new version missed
making a copy of pass-by-ref datum values that it's inserting into Consts.
This is not optional, however, as revealed by buildfarm failures on
machines running -DRELCACHE_FORCE_RELEASE: we're copying from a relcache
entry that could go away before the required lifespan of our output
expression.  I'm pretty sure -DCLOBBER_CACHE_ALWAYS machines won't like
this either, but none of them have reported in yet.

Files

PathChange+/−
src/backend/catalog/partition.c modified +8 −2