Fix possible usage of incorrect UPPERREL_SETOP RelOptInfo
David Rowley <drowley@postgresql.org>
Fix possible usage of incorrect UPPERREL_SETOP RelOptInfo 03d40e4b5 allowed dummy UNION [ALL] children to be removed from the plan by checking for is_dummy_rel(). That commit neglected to still account for the relids from the dummy rel so that the correct UPPERREL_SETOP RelOptInfo could be found and used for adding the Paths to. Not doing this could result in processing of subsequent UNIONs using the same RelOptInfo as a previously processed UNION, which could result in add_path() freeing old Paths that are needed by the previous UNION. The same fix was independently submitted (2 mins later) by Richard Guo. Reported-by: Alexander Lakhin <exclusion@gmail.com> Author: David Rowley <dgrowleyml@gmail.com> Discussion: https://postgr.es/m/bee34aec-659c-46f1-9ab7-7bbae0b7616c@gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/optimizer/prep/prepunion.c | modified | +6 −2 |
| src/test/regress/expected/union.out | modified | +3 −3 |
Discussion
- Teaching planner to short-circuit empty UNION/EXCEPT/INTERSECT inputs 23 messages · 2025-10-02 → 2025-11-06