Test IsInTransactionChain, not IsTransactionBlock, in vac_update_relstats.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: fd0f651a867ce4a25160e37bcb9085f3b3209bf8
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2014-10-30T17:04:06Z
Releases: 9.5.0
Test IsInTransactionChain, not IsTransactionBlock, in vac_update_relstats.

As noted by Noah Misch, my initial cut at fixing bug #11638 didn't cover
all cases where ANALYZE might be invoked in an unsafe context.  We need to
test the result of IsInTransactionChain not IsTransactionBlock; which is
notationally a pain because IsInTransactionChain requires an isTopLevel
flag, which would have to be passed down through several levels of callers.
I chose to pass in_outer_xact (ie, the result of IsInTransactionChain)
rather than isTopLevel per se, as that seemed marginally more apropos
for the intermediate functions to know about.

Files