Use snprintf not sprintf in pg_waldump's timestamptz_to_str.
Tom Lane <tgl@sss.pgh.pa.us>
Use snprintf not sprintf in pg_waldump's timestamptz_to_str. This could only cause an issue if strftime returned a ridiculously long timezone name, which seems unlikely; and it wouldn't qualify as a security problem even then, since pg_waldump (nee pg_xlogdump) is a debug tool not part of the server. But gcc 8 has started issuing warnings about it, so let's use snprintf and be safe. Backpatch to 9.3 where this code was added. Discussion: https://postgr.es/m/21789.1529170195@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| contrib/pg_xlogdump/compat.c | modified | +4 −2 |
Discussion
- GCC 8 warnings 7 messages · 2018-04-24 → 2018-06-16