Horton

Fix off_t overflow in pg_basebackup on Windows.

Thomas Munro <tmunro@postgresql.org>

View on postgr.es
Commit: faee3185aafa3a6055c2558b6fe7b5deb64d5460
Author: Thomas Munro <tmunro@postgresql.org>
Date: 2025-01-09T03:05:01Z
Releases: 17.3 
Fix off_t overflow in pg_basebackup on Windows.

walmethods.c used off_t to navigate around a pg_wal.tar file that could
exceed 2GB, which doesn't work on Windows and would fail with misleading
errors.  Use pgoff_t instead.

Back-patch to all supported branches.

Author: Davinder Singh <davinder.singh@enterprisedb.com>
Reported-by: Jakub Wartak <jakub.wartak@enterprisedb.com>
Discussion: https://postgr.es/m/CAKZiRmyM4YnokK6Oenw5JKwAQ3rhP0YTz2T-tiw5dAQjGRXE3Q%40mail.gmail.com

Files

PathChange+/−
src/bin/pg_basebackup/receivelog.c modified +1 −1
src/bin/pg_basebackup/walmethods.c modified +1 −1
src/bin/pg_basebackup/walmethods.h modified +1 −1

Discussion