Clean up Perl code according to perlcritic

Peter Eisentraut <peter_e@gmx.net>

Commit: facde2a98f0b5f7689b4e30a9e7376e926e733b8
Author: Peter Eisentraut <peter_e@gmx.net>
Date: 2017-03-27T12:18:22Z
Releases: 10.0
Clean up Perl code according to perlcritic

Fix all perlcritic warnings of severity level 5, except in
src/backend/utils/Gen_dummy_probes.pl, which is automatically generated.

Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>

Files

PathChange+/−
contrib/intarray/bench/create_test.pl modified +10 −10
doc/src/sgml/generate-errcodes-table.pl modified +1 −1
doc/src/sgml/mk_feature_tables.pl modified +6 −6
src/backend/catalog/Catalog.pm modified +4 −4
src/backend/catalog/genbki.pl modified +32 −32
src/backend/parser/check_keywords.pl modified +15 −15
src/backend/storage/lmgr/generate-lwlocknames.pl modified +15 −15
src/backend/utils/generate-errcodes.pl modified +1 −1
src/backend/utils/Gen_fmgrtab.pl modified +16 −16
src/bin/pg_basebackup/t/010_pg_basebackup.pl modified +13 −13
src/bin/pg_ctl/t/001_start_stop.pl modified +7 −7
src/bin/psql/create_help.pl modified +14 −14
src/interfaces/ecpg/preproc/check_rules.pl modified +6 −6
src/interfaces/libpq/test/regress.pl modified +7 −7
src/pl/plperl/plc_perlboot.pl modified +3 −1
src/pl/plperl/plc_trusted.pl modified +1 −1
src/pl/plperl/text2macro.pl modified +4 −4
src/pl/plpgsql/src/generate-plerrcodes.pl modified +1 −1
src/pl/plpython/generate-spiexceptions.pl modified +1 −1
src/pl/tcl/generate-pltclerrcodes.pl modified +1 −1
src/test/locale/sort-test.pl modified +3 −3
src/test/perl/PostgresNode.pm modified +4 −4
src/test/perl/TestLib.pm modified +8 −8
src/test/ssl/ServerSetup.pm modified +24 −24
src/tools/fix-old-flex-code.pl modified +2 −2
src/tools/msvc/builddoc.pl modified +1 −1
src/tools/msvc/build.pl modified +4 −4
src/tools/msvc/gendef.pl modified +9 −9
src/tools/msvc/install.pl modified +2 −2
src/tools/msvc/Install.pm modified +5 −5
src/tools/msvc/mkvcbuild.pl modified +2 −2
src/tools/msvc/Mkvcbuild.pm modified +1 −1
src/tools/msvc/pgbison.pl modified +2 −2
src/tools/msvc/pgflex.pl modified +6 −6
src/tools/msvc/Project.pm modified +14 −14
src/tools/msvc/Solution.pm modified +81 −81
src/tools/msvc/vcregress.pl modified +10 −9
src/tools/pginclude/pgcheckdefines modified +16 −16
src/tools/pgindent/pgindent modified +2 −3
src/tools/version_stamp.pl modified +3 −3
src/tools/win32tzlist.pl modified +3 −3