Break transformCreateStmt() into multiple routines and make
Tom Lane <tgl@sss.pgh.pa.us>
Break transformCreateStmt() into multiple routines and make transformAlterStmt() use these routines, instead of having lots of duplicate (not to mention should-have-been-duplicate) code. Adding a column with a CHECK constraint actually works now, and the tests to reject unsupported DEFAULT and NOT NULL clauses actually fire now. ALTER TABLE ADD PRIMARY KEY works, modulo having to have created the column(s) NOT NULL already.
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/ref/alter_table.sgml | modified | +6 −14 |
| src/backend/catalog/pg_type.c | modified | +5 −8 |
| src/backend/commands/command.c | modified | +178 −187 |
| src/backend/parser/analyze.c | modified | +902 −942 |
| src/backend/tcop/utility.c | modified | +2 −2 |
| src/include/commands/command.h | modified | +2 −2 |
| src/include/nodes/parsenodes.h | modified | +8 −3 |
| src/test/regress/expected/alter_table.out | modified | +14 −14 |
| src/test/regress/expected/foreign_key.out | modified | +1 −1 |