Replace pgwin32_is_junction() with lstat().
Thomas Munro <tmunro@postgresql.org>
Author:
Thomas Munro <tmunro@postgresql.org>
Committer:
Andrew Dunstan <andrew@dunslane.net>
Date: 2024-11-07T22:59:40Z
Releases:
15.9
Replace pgwin32_is_junction() with lstat(). Now that lstat() reports junction points with S_IFLNK/S_ISLINK(), and unlink() can unlink them, there is no need for conditional code for Windows in a few places. That was expressed by testing for WIN32 or S_ISLNK, which we can now constant-fold. The coding around pgwin32_is_junction() was a bit suspect anyway, as we never checked for errors, and we also know that errors can be spuriously reported because of transient sharing violations on this OS. The lstat()-based code has handling for that. This also reverts 4fc6b6ee on master only. That was done because lstat() didn't previously work for symlinks (junction points), but now it does. Tested-by: Andrew Dunstan <andrew@dunslane.net> Discussion: https://postgr.es/m/CA%2BhUKGLfOOeyZpm5ByVcAt7x5Pn-%3DxGRNCvgiUPVVzjFLtnY0w%40mail.gmail.com (cherry picked from commit 5fc88c5d53e43fa7dcea93499d230a0bf70f4f77) Author: Thomas Munro <tmunro@postgresql.org> Author: Alexandra Wang <alexandra.wang.oss@gmail.com>
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/backup/basebackup.c | modified | +1 −11 |
| src/backend/commands/tablespace.c | modified | +1 −6 |
| src/backend/storage/file/fd.c | modified | +0 −5 |
| src/backend/utils/adt/misc.c | modified | +0 −7 |
| src/bin/pg_checksums/pg_checksums.c | modified | +0 −4 |
| src/bin/pg_rewind/file_ops.c | modified | +0 −4 |
| src/common/file_utils.c | modified | +0 −23 |
| src/include/port.h | modified | +0 −1 |
| src/include/port/win32_port.h | modified | +0 −1 |
| src/port/dirmod.c | modified | +0 −16 |