Some minor code cleanup, falling out from the removal of rtree. SK_NEGATE
Tom Lane <tgl@sss.pgh.pa.us>
Some minor code cleanup, falling out from the removal of rtree. SK_NEGATE isn't being used anywhere anymore, and there seems no point in a generic index_keytest() routine when two out of three remaining access methods aren't using it. Also, add a comment documenting a convention for letting access methods define private flag bits in ScanKey sk_flags. There are no such flags at the moment but I'm thinking about changing btree's handling of "required keys" to use flag bits in the keys rather than a count of required key positions. Also, if some AM did still want SK_NEGATE then it would be reasonable to treat it as a private flag bit.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/common/indexvalid.c | deleted | +0 −78 |
| src/backend/access/common/Makefile | modified | +2 −3 |
| src/backend/access/gist/gistget.c | modified | +10 −8 |
| src/backend/access/hash/hashutil.c | modified | +35 −4 |
| src/backend/executor/execUtils.c | modified | +2 −4 |
| src/include/access/iqual.h | deleted | +0 −31 |
| src/include/access/skey.h | modified | +8 −3 |