Fix poorly thought-through code from commit 5c3c3cd0a3046339.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: f73b2bbbdcb387aa90ff619fe03d1924ed82b868
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2016-04-11T04:28:44Z
Releases: 9.6.0
Fix poorly thought-through code from commit 5c3c3cd0a3046339.

It's not entirely clear to me whether PyString_AsString can return
null (looks like the answer might vary between Python 2 and 3).
But in any case, this code's attempt to cope with the possibility
was quite broken, because pstrdup() neither allows a null argument
nor ever returns a null.

Moreover, the code below this point assumes that "message" is a
palloc'd string, which would not be the case for a dgettext result.

Fix both problems by doing the pstrdup step separately.

Files

PathChange+/−
src/pl/plpython/plpy_plpymodule.c modified +4 −2