pg_waldump: Fix invalid option handling

Peter Eisentraut <peter@eisentraut.org>

Commit: f65eced25118aab29804debc4e0b9a67f4d043ad
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2019-06-06T08:14:25Z
Releases: 12.0
pg_waldump: Fix invalid option handling

Previously, running pg_waldump with an invalid option (pg_waldump
--foo) would print the help output and exit successfully.  This was
because it tried to process the option letter '?' as a normal option,
but that letter is used by getopt() to report an invalid option.

To fix, process help and version options separately, like we do
everywhere else.  Also add a basic test suite for pg_waldump and run
the basic option handling tests, which would have caught this.

Files