Avoid failure when altering state of partitioned foreign-key triggers.
Tom Lane <tgl@sss.pgh.pa.us>
Avoid failure when altering state of partitioned foreign-key triggers. Beginning in v15, if you apply ALTER TABLE ENABLE/DISABLE TRIGGER to a partitioned table, it also affects the partitions' cloned versions of the affected trigger(s). The initial implementation of this located the clones by name, but that fails on foreign-key triggers which have names incorporating their own OIDs. We can fix that, and also make the behavior more bulletproof in the face of user-initiated trigger renames, by identifying the cloned triggers by tgparentid. Following the lead of earlier commits in this area, I took care not to break ABI in the v15 branch, even though I rather doubt there are any external callers of EnableDisableTrigger. While here, update the documentation, which was not touched when the semantics were changed. Per bug #17817 from Alan Hodgson. Back-patch to v15; older versions do not have this behavior. Discussion: https://postgr.es/m/17817-31dfb7c2100d9f3d@postgresql.org
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/ref/alter_table.sgml | modified | +16 −7 |
| src/backend/commands/tablecmds.c | modified | +3 −2 |
| src/backend/commands/trigger.c | modified | +27 −11 |
| src/include/commands/trigger.h | modified | +3 −0 |
| src/test/regress/expected/triggers.out | modified | +34 −0 |
| src/test/regress/sql/triggers.sql | modified | +15 −0 |
Documentation touched
Discussion
- BUG #17817: DISABLE TRIGGER ALL on a partitioned table with foreign key fails 8 messages · 2023-03-01 → 2023-03-03