Horton

pg_upgrade: Check for the expected error message in TAP tests.

Masahiko Sawada <msawada@postgresql.org>

View on postgr.es
Commit: f52345995d3691de7b0a888903b6cfed1497c672
Author: Masahiko Sawada <msawada@postgresql.org>
Date: 2025-03-04T19:16:12Z
Releases: 18.0 
pg_upgrade: Check for the expected error message in TAP tests.

Since pg_upgrade prints its error messages on stdout, we can't use
command_fails_like() to check if it fails for the right reason. This
commit uses command_checks_all() in pg_upgrade TAP tests to check the
exit status and stdout, enabling proper verification of error
reasons.

Author: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Discussion: https://postgr.es/m/87tt8h1vb7.fsf@wibble.ilmari.org

Files

PathChange+/−
src/bin/pg_upgrade/t/002_pg_upgrade.pl modified +4 −1
src/bin/pg_upgrade/t/004_subscription.pl modified +6 −1
src/bin/pg_upgrade/t/005_char_signedness.pl modified +4 −1

Discussion