Fix multiple minor infelicities in aclchk.c error reports.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: f475fe3538858650aaf55fcc20c3e71a74e0fd56
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2016-06-13T17:53:10Z
Releases: 9.3.14
Fix multiple minor infelicities in aclchk.c error reports.

pg_type_aclmask reported the wrong type's OID when complaining that
it could not find a type's typelem.  It also failed to provide a
suitable errcode when the initially given OID doesn't exist (which
is a user-facing error, since that OID can be user-specified).
pg_foreign_data_wrapper_aclmask and pg_foreign_server_aclmask likewise
lacked errcode specifications.  Trivial cosmetic adjustments too.

The wrong-type-OID problem was reported by Petru-Florin Mihancea in
bug #14186; the other issues noted by me while reading the code.
These errors all seem to be aboriginal in the respective routines, so
back-patch as necessary.

Report: <20160613163159.5798.52928@wrigleys.postgresql.org>

Files

PathChange+/−
src/backend/catalog/aclchk.c modified +14 −9