Avoid unportable strftime() behavior in pg_dump/pg_dumpall.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: f455fcfdb8ca3b67373223a4e15648c35e2592a9
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2014-10-27T00:59:21Z
Releases: 9.5.0
Avoid unportable strftime() behavior in pg_dump/pg_dumpall.

Commit ad5d46a4494b0b480a3af246bb4227d9bdadca37 thought that we could
get around the known portability issues of strftime's %Z specifier by
using %z instead.  However, that idea seems to have been innocent of
any actual research, as it certainly missed the facts that
(1) %z is not portable to pre-C99 systems, and
(2) %z doesn't actually act differently from %Z on Windows anyway.

Per failures on buildfarm member hamerkop.

While at it, centralize the code defining what strftime format we
want to use in pg_dump; three copies of that string seems a bit much.

Files

PathChange+/−
src/bin/pg_dump/dumputils.h modified +17 −0
src/bin/pg_dump/pg_backup_archiver.c modified +5 −3
src/bin/pg_dump/pg_dumpall.c modified +3 −3