Fix handling of all-zero pages in SP-GiST vacuum.

Heikki Linnakangas <heikki.linnakangas@iki.fi>

Commit: f4297f8c5fd457a54671947023f8b56237b952db
Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: 2015-07-27T09:32:48Z
Releases: 9.2.14
Fix handling of all-zero pages in SP-GiST vacuum.

SP-GiST initialized an all-zeros page at vacuum, but that was not
WAL-logged, which is not safe. You might get a torn page write, when it gets
flushed to disk, and end-up with a half-initialized index page. To fix,
leave it in the all-zeros state, and add it to the FSM. It will be
initialized when reused. Also don't set the page-deleted flag when recycling
an empty page. That was also not WAL-logged, and a torn write of that would
cause the page to have an invalid checksum.

Backpatch to 9.2, where SP-GiST indexes were added.

Files