Move PG_TEMP_FILE* macros to file_utils.h.
Nathan Bossart <nathan@postgresql.org>
Move PG_TEMP_FILE* macros to file_utils.h. Presently, frontend code that needs to use these macros must either include storage/fd.h, which declares several frontend-unsafe functions, or duplicate the macros. This commit moves these macros to common/file_utils.h, which is safe for both frontend and backend code. Consequently, we can also remove the duplicated macros in pg_checksums and stop including storage/fd.h in pg_rewind. Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/ZOP5qoUualu5xl2Z%40paquier.xyz
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/backup/basebackup.c | modified | +1 −1 |
| src/backend/postmaster/postmaster.c | modified | +1 −0 |
| src/backend/storage/file/fileset.c | modified | +1 −0 |
| src/bin/pg_checksums/pg_checksums.c | modified | +0 −10 |
| src/bin/pg_rewind/filemap.c | modified | +1 −1 |
| src/include/common/file_utils.h | modified | +4 −0 |
| src/include/storage/fd.h | modified | +0 −4 |
Discussion
- should frontend tools use syncfs() ? 50 messages · 2021-09-30 → 2023-10-13