Fix portability and safety issues in pqTraceFormatTimestamp.
Tom Lane <tgl@sss.pgh.pa.us>
Fix portability and safety issues in pqTraceFormatTimestamp. Remove confusion between time_t and pg_time_t; neither gettimeofday() nor localtime() deal in the latter. libpq indeed has no business using <pgtime.h> at all. Use snprintf not sprintf, to ensure we can't overrun the supplied buffer. (Unlikely, but let's be safe.) Per buildfarm.
Files
| Path | Change | +/− |
|---|---|---|
| src/interfaces/libpq/fe-trace.c | modified | +3 −6 |