Tighten TAP tests' tracking of postmaster state some more.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: f0b0b1ddb53a66e57404cd1bfa4aa2944c3e77c6
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2022-01-20T22:28:07Z
Releases: 12.10
Tighten TAP tests' tracking of postmaster state some more.

Commits 6c4a8903b et al. had a couple of deficiencies:

* The logic I added to Cluster::start to see if a PID file is present
could be fooled by a stale PID file left over from a previous
postmaster.  To fix, if we're not sure whether we expect to find a
running postmaster or not, validate the PID using "kill 0".

* 017_shm.pl has a loop in which it just issues repeated Cluster::start
calls; this will fail if some invocation fails but leaves self->_pid
set.  Per buildfarm results, the above fix is not enough to make this
safe: we might have "validated" a PID for a postmaster that exits
immediately after we look.  Hence, match each failed start call with
a stop call that will get us back to the self->_pid == undef state.
Add a fail_ok option to Cluster::stop to make this work.

Discussion: https://postgr.es/m/CA+hUKGKV6fOHvfiPt8=dOKzvswjAyLoFoJF1iQXMNpi7+hD1JQ@mail.gmail.com

Files

PathChange+/−
src/test/perl/PostgresNode.pm modified +34 −6
src/test/recovery/t/017_shm.pl modified +3 −0

Discussion

Cited messages not in the archive: CA+hUKGKV6fOHvfiPt8=dOKzvswjAyLoFoJF1iQXMNpi7+hD1JQ@mail.gmail.com