Fix compute_scalar_stats() for case that all values exceed WIDTH_THRESHOLD.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: f0381680fa480a8794d00566cef21178cd63d74e
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2014-01-11T18:41:56Z
Releases: 9.2.7
Fix compute_scalar_stats() for case that all values exceed WIDTH_THRESHOLD.

The standard typanalyze functions skip over values whose detoasted size
exceeds WIDTH_THRESHOLD (1024 bytes), so as to limit memory bloat during
ANALYZE.  However, we (I think I, actually :-() failed to consider the
possibility that *every* non-null value in a column is too wide.  While
compute_minimal_stats() seems to behave reasonably anyway in such a case,
compute_scalar_stats() just fell through and generated no pg_statistic
entry at all.  That's unnecessarily pessimistic: we can still produce
valid stanullfrac and stawidth values in such cases, since we do include
too-wide values in the average-width calculation.  Furthermore, since the
general assumption in this code is that too-wide values are probably all
distinct from each other, it seems reasonable to set stadistinct to -1
("all distinct").

Per complaint from Kadri Raudsepp.  This has been like this since roughly
neolithic times, so back-patch to all supported branches.

Files

PathChange+/−
src/backend/commands/analyze.c modified +15 −1