Allow concurrent-safe open() and fopen() in frontend code for Windows
Michael Paquier <michael@paquier.xyz>
Allow concurrent-safe open() and fopen() in frontend code for Windows PostgreSQL uses a custom wrapper for open() and fopen() which is concurrent-safe, allowing multiple processes to open and work on the same file. This has a couple of advantages: - pg_test_fsync does not handle O_DSYNC correctly otherwise, leading to false claims that disks are unsafe. - TAP tests can run into race conditions when a postmaster and pg_ctl open postmaster.pid, fixing some random failures in the buildfam. pg_upgrade is one frontend tool using workarounds to bypass file locking issues with the log files it generates, however the interactions with pg_ctl are proving to be tedious to get rid of, so this is left for later. Author: Laurenz Albe Reviewed-by: Michael Paquier, Kuntal Ghosh Discussion: https://postgr.es/m/1527846213.2475.31.camel@cybertec.at Discussion: https://postgr.es/m/16922.1520722108@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| src/bin/initdb/initdb.c | modified | +8 −0 |
| src/bin/pg_basebackup/pg_receivewal.c | modified | +1 −1 |
| src/bin/pg_verify_checksums/pg_verify_checksums.c | modified | +1 −1 |
| src/common/file_utils.c | modified | +2 −2 |
| src/include/port.h | modified | +0 −3 |
Discussion
- Loaded footgun open_datasync on Windows 39 messages · 2018-06-01 → 2020-07-27
- Intermittent pg_ctl failures on Windows 16 messages · 2018-03-10 → 2019-07-19