Prevent parser from believing that views have system columns.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: f01936f70b58dec8136399f6258b37d762c3cec3
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2012-10-24T18:53:58Z
Releases: 9.1.7
Prevent parser from believing that views have system columns.

Views should not have any pg_attribute entries for system columns.
However, we forgot to remove such entries when converting a table to a
view.  This could lead to crashes later on, if someone attempted to
reference such a column, as reported by Kohei KaiGai.

This problem is corrected properly in HEAD (by removing the pg_attribute
entries during conversion), but in the back branches we need to defend
against existing mis-converted views.  This fix costs us an extra syscache
lookup per system column reference, which is annoying but probably not
really measurable in the big scheme of things.

Files