Cast to (void *) rather than (int *) when passing int64's to PQfn().

Tom Lane <tgl@sss.pgh.pa.us>

Commit: ef75508efc789c79c5a5d4acd7ad5da85f1e4f08
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2015-03-08T17:58:28Z
Releases: 9.5.0
Cast to (void *) rather than (int *) when passing int64's to PQfn().

This is a possibly-vain effort to silence a Coverity warning about
bogus endianness dependency.  The code's fine, because it takes care
of endianness issues for itself, but Coverity sees an int64 being
passed to an int* argument and not unreasonably suspects something's
wrong.  I'm not sure if putting the void* cast in the way will shut it
up; but it can't hurt and seems better from a documentation standpoint
anyway, since the pointer is not used as an int* in this code path.

Just for a bit of additional safety, verify that the result length
is 8 bytes as expected.

Back-patch to 9.3 where the code in question was added.

Files

PathChange+/−
src/interfaces/libpq/fe-lobj.c modified +5 −5