Lock table in DROP STATISTICS

Tomas Vondra <tomas.vondra@postgresql.org>

Commit: ee32b824dcc1c9e7efdc065dd152eed39bd97e13
Author: Tomas Vondra <tomas.vondra@postgresql.org>
Date: 2023-11-19T20:03:50Z
Releases: 16.2
Lock table in DROP STATISTICS

The DROP STATISTICS code failed to properly lock the table, leading to

  ERROR:  tuple concurrently deleted

when executed concurrently with ANALYZE.

Fixed by modifying RemoveStatisticsById() to acquire the same lock as
ANALYZE. This function is called only by DROP STATISTICS, as ANALYZE
calls RemoveStatisticsDataById() directly.

Reported by Justin Pryzby, fix by me. Backpatch through 12. The code was
like this since it was introduced in 10, but older releases are EOL.

Reported-by: Justin Pryzby
Reviewed-by: Tom Lane
Backpatch-through: 12

Discussion: https://postgr.es/m/ZUuk-8CfbYeq6g_u@pryzbyj2023

Files

PathChange+/−
src/backend/commands/statscmds.c modified +15 −8

Discussion