Horton

Perform a lot more sanity checks when freezing tuples.

Andres Freund <andres@anarazel.de>

View on postgr.es
Commit: ed8e1aff6acef475eb33e0212253df05cb2d4d20
Author: Andres Freund <andres@anarazel.de>
Date: 2017-12-15T02:20:48Z
Releases: 9.4.16 
Perform a lot more sanity checks when freezing tuples.

The previous commit has shown that the sanity checks around freezing
aren't strong enough. Strengthening them seems especially important
because the existance of the bug has caused corruption that we don't
want to make even worse during future vacuum cycles.

The errors are emitted with ereport rather than elog, despite being
"should never happen" messages, so a proper error code is emitted. To
avoid superflous translations, mark messages as internal.

Author: Andres Freund and Alvaro Herrera
Reviewed-By: Alvaro Herrera, Michael Paquier
Discussion: https://postgr.es/m/20171102112019.33wb7g5wp4zpjelu@alap3.anarazel.de
Backpatch: 9.3-

Files

PathChange+/−
src/backend/access/heap/heapam.c modified +104 −18
src/backend/access/heap/rewriteheap.c modified +4 −1
src/backend/commands/vacuumlazy.c modified +13 −2
src/include/access/heapam.h modified +3 −2
src/include/access/heapam_xlog.h modified +2 −0

Discussion