Forbid invalid combination of options in pg_basebackup.

Fujii Masao <fujii@postgresql.org>

Commit: ecbdc4c555f43b1ac284c734752b00c2ea6f277b
Author: Fujii Masao <fujii@postgresql.org>
Date: 2016-12-21T11:27:37Z
Releases: 10.0
Forbid invalid combination of options in pg_basebackup.

Commit 56c7d8d4552180fd66fe48423bb2a9bb767c2d87 allowed pg_basebackup
to stream WAL in tar mode. But there is the restriction that WAL
streaming in tar mode works only when the value - (dash) is not
specified as output directory. This means that the combination of
three options "-D -", "-F t" and "-X stream" is invalid. However,
previously, even when those options were specified at the same time,
pg_basebackup background process unexpectedly started streaming WAL.
And then it exited with an error.

This commit changes pg_basebackup so that it errors out on such
invalid combination of options at the beginning.

Reviewed by Magnus Hagander, and patch by me.

Files

PathChange+/−
src/bin/pg_basebackup/pg_basebackup.c modified +10 −0