Add TupleDescGetDefault()
Peter Eisentraut <peter@eisentraut.org>
Add TupleDescGetDefault() This unifies some repetitive code. Note: I didn't push the "not found" error message into the new function, even though all existing callers would be able to make use of it. Using the existing error handling as-is would probably require exposing the Relation type via tupdesc.h, which doesn't seem desirable. (Or even if we changed it to just report the OID, it would inject the concept of a relation containing the tuple descriptor into tupdesc.h, which might be a layering violation. Perhaps some further improvements could be considered here separately.) Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e4da%40eisentraut.org
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/common/tupdesc.c | modified | +25 −0 |
| src/backend/commands/tablecmds.c | modified | +2 −15 |
| src/backend/parser/parse_utilcmd.c | modified | +2 −11 |
| src/backend/rewrite/rewriteHandler.c | modified | +1 −15 |
| src/include/access/tupdesc.h | modified | +2 −0 |
Discussion
- tablecmds.c/MergeAttributes() cleanup 32 messages · 2023-06-28 → 2024-05-03