Horton

Fix get_useful_pathkeys_for_relation for volatile expressions

Tomas Vondra <tomas.vondra@postgresql.org>

View on postgr.es
Commit: ebb7ae839d033d0f279670e249f54646a08b8c48
Author: Tomas Vondra <tomas.vondra@postgresql.org>
Date: 2020-11-03T21:31:57Z
Releases: 14.0 
Fix get_useful_pathkeys_for_relation for volatile expressions

When considering Incremental Sort below a Gather Merge, we need to be
a bit more careful when matching pathkeys to EC members. It's not enough
to find a member whose Vars are all in the current relation's target;
volatile expressions in particular need to be contained in the target,
otherwise it's too early to use the pathkey.

Reported-by: Jaime Casanova
Author: James Coleman
Reviewed-by: Tomas Vondra
Backpatch-through: 13, where the incremental sort code was added
Discussion: https://postgr.es/m/CAJGNTeNaxpXgBVcRhJX%2B2vSbq%2BF2kJqGBcvompmpvXb7pq%2BoFA%40mail.gmail.com

Files

PathChange+/−
src/backend/optimizer/path/allpaths.c modified +7 −6
src/backend/optimizer/path/equivclass.c modified +70 −0
src/include/optimizer/paths.h modified +1 −0
src/test/regress/expected/incremental_sort.out modified +98 −0
src/test/regress/sql/incremental_sort.sql modified +31 −0

Discussion