Use --strip-unneeded when stripping static libraries with GNU strip.
Tom Lane <tgl@sss.pgh.pa.us>
Use --strip-unneeded when stripping static libraries with GNU strip. We've long used "--strip-unneeded" for shared libraries but plain "-x" for static libraries when stripping symbols with GNU strip. There doesn't seem to be any really good reason for that though, since --strip-unneeded produces smaller output (as "-x" alone does not remove debug symbols). Moreover it seems that llvm-strip, although it identifies as GNU strip, misbehaves when given "-x" for this purpose. It's unclear whether that's intentional or a bug in llvm-strip, but in any case it seems like changing to use --strip-unneeded in all cases should be a win. Note that this doesn't change our behavior when dealing with non-GNU strip. Per gripes from Ed Maste and Palle Girgensohn. Back-patch, in case anyone wants to use llvm-strip with stable branches. Discussion: https://postgr.es/m/17898-5308d09543463266@postgresql.org Discussion: https://postgr.es/m/20230420153338.bbj2g5jiyy3afhjz@awork3.anarazel.de
Files
| Path | Change | +/− |
|---|---|---|
| config/programs.m4 | modified | +1 −1 |
| configure | modified | +1 −1 |
| src/makefiles/meson.build | modified | +1 −1 |
Discussion
- Re: LLVM strip -x fails 9 messages · 2023-04-20 → 2023-04-21
- BUG #17898: Build failure when strip is LLVM's version 2 messages · 2023-04-15 → 2023-04-20