Fix MVCC bug with prepared xact with subxacts on standby

Heikki Linnakangas <heikki.linnakangas@iki.fi>

Commit: e9c8747ee934db9b5bad0b0f5aa3709a41ad0a9c
Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: 2024-06-27T18:08:55Z
Releases: 13.16
Fix MVCC bug with prepared xact with subxacts on standby

We did not recover the subtransaction IDs of prepared transactions
when starting a hot standby from a shutdown checkpoint. As a result,
such subtransactions were considered as aborted, rather than
in-progress. That would lead to hint bits being set incorrectly, and
the subtransactions suddenly becoming visible to old snapshots when
the prepared transaction was committed.

To fix, update pg_subtrans with prepared transactions's subxids when
starting hot standby from a shutdown checkpoint. The snapshots taken
from that state need to be marked as "suboverflowed", so that we also
check the pg_subtrans.

Backport to all supported versions.

Discussion: https://www.postgresql.org/message-id/6b852e98-2d49-4ca1-9e95-db419a2696e0@iki.fi

Files

Discussion