Horton

Avoid bogus TwoPhaseState locking sequences

Alvaro Herrera <alvherre@alvh.no-ip.org>

View on postgr.es
Commit: e90ceeaa495f5f40f224bcf84d2b0700eae8d7a3
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2017-06-14T15:29:05Z
Releases: 10.0 
Avoid bogus TwoPhaseState locking sequences

The optimized code in 728bd991c3c4 contains a few invalid locking
sequences.  To wit, the original code would try to acquire an lwlock
that it already holds.  Avoid this by moving lock acquisitions to
higher-level code, and install appropriate assertions in low-level that
the correct mode is held.

Authors: Michael Paquier, Álvaro Herrera
Reported-By: chuanting wang
Bug: #14680
Discussion: https://postgr.es/m/20170531033228.1487.10124@wrigleys.postgresql.org

Files

PathChange+/−
src/backend/access/transam/twophase.c modified +47 −40
src/backend/access/transam/xact.c modified +36 −32

Discussion