Fix self-join removal to update bare Var references in join clauses
Alexander Korotkov <akorotkov@postgresql.org>
Fix self-join removal to update bare Var references in join clauses Self-join removal failed to update Var nodes when the join clause was a bare Var (e.g., ON t1.bool_col) rather than an expression containing Vars. ChangeVarNodesWalkExpression() used expression_tree_walker(), which descends into child nodes but does not process the top-level node itself. When a bare Var referencing the removed relation appeared as the clause, its varno was left unchanged, leading to "no relation entry for relid N" errors. Fix by calling ChangeVarNodes_walker() directly instead of expression_tree_walker(), so the top-level node is also processed. Bug: #19435 Reported-by: Hang Ammmkilo <ammmkilo@163.com> Author: Andrei Lepikhov <lepihov@gmail.com> Co-authored-by: Tender Wang <tndrwang@gmail.com> Co-authored-by: Alexander Korotkov <aekorotkov@gmail.com> Reviewed-by: Kirill Reshke <reshkekirill@gmail.com> Discussion: https://www.postgresql.org/message-id/flat/19435-3cc1a87f291129f1%40postgresql.org Backpatch-through: 18
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/rewrite/rewriteManip.c | modified | +1 −3 |
| src/test/regress/expected/join.out | modified | +16 −0 |
| src/test/regress/sql/join.sql | modified | +6 −0 |
Discussion
- BUG #19435: Error: "No relation entry for relid 2" Triggered by Complex Join with Self-Referencing Tables 34 messages · 2026-03-16 → 2026-05-25