Fix maintenance hazards caused by ill-considered use of default: cases.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: e84c0195980f24b1c7f857b88834c1dcaf20a102
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2017-05-14T17:32:59Z
Releases: 10.0
Fix maintenance hazards caused by ill-considered use of default: cases.

Remove default cases from assorted switches over ObjectClass and some
related enum types, so that we'll get compiler warnings when someone
adds a new enum value without accounting for it in all these places.

In passing, re-order some switch cases as needed to match the declaration
of enum ObjectClass.  OK, that's just neatnik-ism, but I dislike code
that looks like it was assembled with the help of a dartboard.

Discussion: https://postgr.es/m/20170512221010.nglatgt5azzdxjlj@alvherre.pgsql

Files

Discussion