Horton

Fix cleanup lock acquisition in SPLIT_ALLOCATE_PAGE replay.

Amit Kapila <akapila@postgresql.org>

View on postgr.es
Commit: e848be60b5cf9a883765ea8e98c411e7fef0c1c6
Author: Amit Kapila <akapila@postgresql.org>
Date: 2022-11-14T05:13:33Z
Releases: 16.0 
Fix cleanup lock acquisition in SPLIT_ALLOCATE_PAGE replay.

During XLOG_HASH_SPLIT_ALLOCATE_PAGE replay, we were checking for a
cleanup lock on the new bucket page after acquiring an exclusive lock on
it and raising a PANIC error on failure. However, it is quite possible
that checkpointer can acquire the pin on the same page before acquiring a
lock on it, and then the replay will lead to an error. So instead, directly
acquire the cleanup lock on the new bucket page during
XLOG_HASH_SPLIT_ALLOCATE_PAGE replay operation.

Reported-by: Andres Freund
Author: Robert Haas
Reviewed-By: Amit Kapila, Andres Freund, Vignesh C
Backpatch-through: 11
Discussion: https://postgr.es/m/20220810022617.fvjkjiauaykwrbse@awork3.anarazel.de

Files

PathChange+/−
src/backend/access/hash/hashpage.c modified +7 −3
src/backend/access/hash/hash_xlog.c modified +2 −3

Discussion